Hashes - Fix JSON parsing function of numerals formatted as scientific notation with uppercase E #1580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since we now have regex, this could be improved further for more edge cases. |
|
@BaerMitUmlaut I can modify the tokenizer to use a regex to validate the number parsed, but what should it do if an invalid numeric token is found? The rest of the code seems to do no validation whatsoever and just assumes the JSON is valid (e.g here). If the intent is for an invalid JSON document to crash the script, is regex parsing necessary (since |
|
Good point. Let's leave it like this (with your change) unless we add proper error handling. |
BaerMitUmlaut
approved these changes
Jun 28, 2023
jonpas
approved these changes
Jun 28, 2023
PabstMirror
approved these changes
Sep 2, 2023
jonpas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On both the json.org site and the relevant ECMA-404 specification a
numbersymbol is defined as containing anexponentsymbol which may be: empty, "e" (U+0065, LATIN SMALL LETTER E), or "E" (U+0045, LATIN CAPITAL LETTER E).The current parsing code will error on numbers using the capital "E" syntax such as
1.2E5.When merged this pull request will:
Implement the ability to parse numbers in scientific notation using capital "E" by adding the relevant token to the
_numericvariable. The SQF script commandparseNumberalready handles numbers using uppercase "E" as an exponent delimiter without issue so no changes are required elsewhere (i.e. we do not need to casefold the lexed numeric token prior to feeding into the scripting engine).